Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests/Tokenizer(s): fix typo in directory name and rename some test files #643

Merged
merged 3 commits into from
Oct 24, 2024
Merged

Tests/Tokenizer(s): fix typo in directory name and rename some test files #643

merged 3 commits into from
Oct 24, 2024

Commits on Oct 24, 2024

  1. Tests/Tokenizer(s): fix typo in directory name 

    Follow up on 492

The directory name of the tests should mirror the directory (and class) name of the code under test, but contained a typo. Fixed now.
    @jrfnl
    jrfnl committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    540e8c3 View commit details
    Browse the repository at this point in the history

  2. Tests/Tokenizer: rename two tests 

    Follow up on squizlabs/PHP_CodeSniffer 3639 and 585 which introduced these tests.

While there are no strict naming conventions for the `Core\Tokenizers\Tokenizer` tests, most tests in this directory now include the name of the method being covered by the test in the test class/file name.

That was not the case for these two test classes. Fixed now.

Includes moving the `@covers` tag from method level to class level.
    @jrfnl
    jrfnl committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    e07a5da View commit details
    Browse the repository at this point in the history

  3. Tests/Tokenizer: rename a test 

    Follow up on squizlabs/PHP_CodeSniffer 3066 which introduced this test.

While there are no strict naming conventions for the `Core\Tokenizers\Tokenizer` tests, most tests in this directory now include the name of the method being covered by the test in the test class/file name.

That was not the case for this test class. Fixed now.
    @jrfnl
    jrfnl committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    1bf4e42 View commit details
    Browse the repository at this point in the history