Tests/Tokenizer(s): fix typo in directory name and rename some test files #643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow up on 492 The directory name of the tests should mirror the directory (and class) name of the code under test, but contained a typo. Fixed now.
Follow up on squizlabs/PHP_CodeSniffer 3639 and 585 which introduced these tests. While there are no strict naming conventions for the `Core\Tokenizers\Tokenizer` tests, most tests in this directory now include the name of the method being covered by the test in the test class/file name. That was not the case for these two test classes. Fixed now. Includes moving the `@covers` tag from method level to class level.
Follow up on squizlabs/PHP_CodeSniffer 3066 which introduced this test. While there are no strict naming conventions for the `Core\Tokenizers\Tokenizer` tests, most tests in this directory now include the name of the method being covered by the test in the test class/file name. That was not the case for this test class. Fixed now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tests/Tokenizer(s): fix typo in directory name
Follow up on #492
The directory name of the tests should mirror the directory (and class) name of the code under test, but contained a typo. Fixed now.
Tests/Tokenizer: rename two tests
Follow up on squizlabs/PHP_CodeSniffer#3639 and #585 which introduced these tests.
While there are no strict naming conventions for the
Core\Tokenizers\Tokenizertests, most tests in this directory now include the name of the method being covered by the test in the test class/file name.That was not the case for these two test classes. Fixed now.
Includes moving the
@coverstag from method level to class level.Tests/Tokenizer: rename a test
Follow up on squizlabs/PHP_CodeSniffer#3066 which introduced this test.
While there are no strict naming conventions for the
Core\Tokenizers\Tokenizertests, most tests in this directory now include the name of the method being covered by the test in the test class/file name.That was not the case for this test class. Fixed now.
Suggested changelog entry
N/A