Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow zero bounds for log parameters #83

Merged
merged 1 commit into from
Nov 7, 2021
Merged

Conversation

FFroehlich
Copy link
Collaborator

if there is no finiteness check for upper bound, I don't see why we should prevent lower bound 0 for log scale parameter, it convenient for specifying unbounded parameters after all.

@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2021

Codecov Report

Merging #83 (4a18854) into develop (0a2de3b) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop      #83   +/-   ##
========================================
  Coverage    79.59%   79.59%           
========================================
  Files           26       26           
  Lines         2940     2940           
  Branches       695      695           
========================================
  Hits          2340     2340           
  Misses         423      423           
  Partials       177      177           
Impacted Files Coverage Δ
petab/lint.py 77.10% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a2de3b...4a18854. Read the comment docs.

Copy link
Member

@dweindl dweindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed

@FFroehlich FFroehlich merged commit 9047f2b into develop Nov 7, 2021
@FFroehlich FFroehlich deleted the fix_bound_checking branch November 7, 2021 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants