Skip to content

Commit

Permalink
allow zero bounds for log parameters (#83)
Browse files Browse the repository at this point in the history
  • Loading branch information
Fabian Fröhlich authored Nov 7, 2021
1 parent 0a2de3b commit 9047f2b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion petab/lint.py
Original file line number Diff line number Diff line change
Expand Up @@ -466,7 +466,7 @@ def check_parameter_bounds(parameter_df: pd.DataFrame) -> None:
raise AssertionError(
f"{LOWER_BOUND} greater than {UPPER_BOUND} for "
f"{PARAMETER_ID} {row.name}.")
if (row[LOWER_BOUND] <= 0.0 or row[UPPER_BOUND] < 0.0) \
if (row[LOWER_BOUND] < 0.0 or row[UPPER_BOUND] < 0.0) \
and row[PARAMETER_SCALE] in [LOG, LOG10]:
raise AssertionError(
f"Bounds for {row[PARAMETER_SCALE]} scaled parameter "
Expand Down

0 comments on commit 9047f2b

Please sign in to comment.