Skip to content

Conversation

@dweindl
Copy link
Member

@dweindl dweindl commented Dec 18, 2023

No description provided.

dweindl and others added 3 commits December 14, 2023 22:42
…rvableParameter overrides as placeholders in noise formulae (#235)

Fixes #234

Also fixes return type annotation, makes test more readable, and uses more informative assertions.
Fixed ordering of replicates by timepoints
The visualization examples were pretty redundant. Merged them into a single notebook. Removed redundant blocks.

Furthermore:
* Don't use deprecated `Problem.from_files`
* Simplify by not loading all files separately
* Fix grammar / typos
* Add replicate plot example
* Make plots more readable
* ...

:eyes: https://petab--236.org.readthedocs.build/projects/libpetab-python/en/236/example/example_visualization.html#

Co-authored-by: Maren Philipps <55318391+m-philipps@users.noreply.github.com>
@dweindl dweindl requested a review from dilpath December 18, 2023 09:12
@dweindl dweindl requested review from a team and plakrisenko as code owners December 18, 2023 09:12
@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4e6a018) 76.28% compared to head (097a15e) 76.30%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #238      +/-   ##
==========================================
+ Coverage   76.28%   76.30%   +0.02%     
==========================================
  Files          34       34              
  Lines        3188     3191       +3     
  Branches      774      774              
==========================================
+ Hits         2432     2435       +3     
  Misses        554      554              
  Partials      202      202              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dilpath dilpath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dweindl dweindl merged commit eb08318 into main Dec 18, 2023
@dweindl dweindl deleted the release_0.2.6 branch December 18, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants