Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplification of PEtab problems #172

Merged
merged 9 commits into from
Aug 4, 2022
Merged

Simplification of PEtab problems #172

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
bc47030
Simplification of PEtab problems
dweindl Aug 3, 2022
c58dba8
Update petab/simplify.py
dweindl Aug 4, 2022
a5607cb
Update tests/test_simplify.py
dweindl Aug 4, 2022
21b415c
Update tests/test_simplify.py
dweindl Aug 4, 2022
b8e7ce7
Merge branch 'develop' into simplify
dweindl Aug 4, 2022
925ebf0
Remove O
dweindl Aug 4, 2022
2e22f06
Update tests/test_simplify.py
dweindl Aug 4, 2022
8902702
Update tests/test_simplify.py
dweindl Aug 4, 2022
a9b5ee7
more asserts
dweindl Aug 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove O
  • Loading branch information
@dweindl
dweindl committed Aug 4, 2022
commit 925ebf0d564b04e6b019cc1c732c6410a5aa407b
9 changes: 4 additions & 5 deletions petab/simplify.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

import pandas as pd

import petab
from . import Problem
from .C import * # noqa: F403
from .lint import lint_problem
Expand Down Expand Up @@ -72,12 +73,10 @@ def condition_parameters_to_parameter_table(problem: Problem):
continue

series = problem.condition_df[parameter_id]
if series.dtype == 'o':
# We don't touch parametric overrides
continue
value = petab.to_float_if_float(series[0])

# same value for all conditions?
if len(series.unique()) == 1:
# same value for all conditions and no parametric overrides (str)?
if isinstance(value, float) and len(series.unique()) == 1:
replacements[parameter_id] = series[0]

if not replacements:
Expand Down