Simplification of PEtab problems #172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds some functions to simplify / clean existing PEtab problems: * removing unused conditions * moving parameters that aren't really condition-dependent from the conditions table to the parameters table
dilpath
approved these changes
Aug 4, 2022
Member
dilpath
left a comment
dilpath
left a comment
There was a problem hiding this comment.
Looks good 👍 Fine as is except for the PARAMETER_NAME comment
tests/test_simplify.py
Outdated
| "some_parameter": [1.0, 2.0, 3.0], | ||
| } | ||
| ) | ||
| expected.set_index(CONDITION_ID, inplace=True) |
tests/test_simplify.py
Outdated
| NOMINAL_VALUE: [4.0], | ||
| ESTIMATE: [0], | ||
| }) | ||
| expected.set_index(PARAMETER_ID, inplace=True) |
Co-authored-by: Dilan Pathirana <59329744+dilpath@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## develop #172 +/- ##
===========================================
+ Coverage 77.50% 78.44% +0.93%
===========================================
Files 29 30 +1
Lines 2601 2649 +48
Branches 594 606 +12
===========================================
+ Hits 2016 2078 +62
+ Misses 430 411 -19
- Partials 155 160 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Co-authored-by: Dilan Pathirana <59329744+dilpath@users.noreply.github.com>
Co-authored-by: Dilan Pathirana <59329744+dilpath@users.noreply.github.com>
Co-authored-by: Dilan Pathirana <59329744+dilpath@users.noreply.github.com>
Co-authored-by: Dilan Pathirana <59329744+dilpath@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some functions to simplify / clean existing PEtab problems: