-
Notifications
You must be signed in to change notification settings - Fork 7
Simplify test model creation - use simplesbml #139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #139 +/- ##
===========================================
- Coverage 77.22% 76.75% -0.47%
===========================================
Files 27 27
Lines 2955 2956 +1
Branches 718 724 +6
===========================================
- Hits 2282 2269 -13
- Misses 489 507 +18
+ Partials 184 180 -4
Continue to review full report at Codecov.
|
dilpath
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine to merge as is
| sbml.add_global_parameter(model, 'parameter1') | ||
| sbml.add_global_parameter(model, 'noiseParameter1_') | ||
| sbml.add_global_parameter(model, 'observableParameter1_') | ||
| import simplesbml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move to header? Currently imported multiple times.
Also imported within test cases in other files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea was not importing bulky libsbml everywhere, that when running non-sbml only, they will complete slightly faster (e.g., convenient when using auto-rerun).
|
|
||
| # compartment missing in model | ||
| condition_df['c1'] = [4.0] | ||
| condition_df['c2'] = [4.0] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Compartment name changed? Is it that the default compartment in a simplesbml.SbmlModel is already 'c1'?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, exactly.
No description provided.