Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ancient deprecated functions related to specifying observables/noise models inside SBML #140

Merged
merged 5 commits into from
Apr 29, 2022

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Apr 28, 2022

They are obsolete since the introduction of the observable table.

@codecov-commenter
Copy link

Codecov Report

Merging #140 (ae55288) into develop (93d7f60) will increase coverage by 0.41%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #140      +/-   ##
===========================================
+ Coverage    77.30%   77.72%   +0.41%     
===========================================
  Files           27       27              
  Lines         2956     2904      -52     
  Branches       724      718       -6     
===========================================
- Hits          2285     2257      -28     
+ Misses         488      468      -20     
+ Partials       183      179       -4     
Impacted Files Coverage Δ
petab/core.py 87.90% <ø> (+0.88%) ⬆️
petab/sbml.py 63.15% <100.00%> (+3.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93d7f60...ae55288. Read the comment docs.

@dweindl
Copy link
Member Author

dweindl commented Apr 28, 2022

@dweindl dweindl marked this pull request as ready for review April 29, 2022 08:38
@dweindl dweindl requested a review from dilpath April 29, 2022 08:38
@dweindl dweindl requested a review from FFroehlich April 29, 2022 12:59
@dweindl dweindl merged commit 5d8f7ff into develop Apr 29, 2022
@dweindl dweindl deleted the remove_deprecated_sbmlobs branch April 29, 2022 13:07
dweindl added a commit to AMICI-dev/AMICI that referenced this pull request May 3, 2022
dweindl added a commit to AMICI-dev/AMICI that referenced this pull request May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants