Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix, test and deprecate petab.sbml.constant_species_to_parameters #122

Merged
merged 3 commits into from
Aug 18, 2019
Merged

Fix, test and deprecate petab.sbml.constant_species_to_parameters #122

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
573c5a6
Fix, test and deprecate petab.sbml.constant_species_to_parameters
dweindl Aug 9, 2019
f106711
doc
dweindl Aug 9, 2019
fb09010
Merge branch 'develop' into fix_constant_species_to_parameters
paulstapor Aug 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
doc
  • Loading branch information
@dweindl
dweindl committed Aug 9, 2019
commit f106711a0c771bdba99c14f73852d900c5937e4f
1 change: 1 addition & 0 deletions petab/sbml.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@ def constant_species_to_parameters(sbml_model: libsbml.Model) -> list:
# Remove from reactants and products
for reaction in sbml_model.getListOfReactions():
for speciesId in transformables:
# loop, since removeX only removes one instance
while reaction.removeReactant(speciesId):
dweindl marked this conversation as resolved.
Show resolved Hide resolved
pass
while reaction.removeProduct(speciesId):
Expand Down