Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix, test and deprecate petab.sbml.constant_species_to_parameters #122

Merged
merged 3 commits into from
Aug 18, 2019

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Aug 9, 2019

Function failed in case of multiple occurrences of the same species.

@dweindl dweindl requested a review from yannikschaelte August 9, 2019 13:25
petab/sbml.py Show resolved Hide resolved
@codecov-io
Copy link

Codecov Report

Merging #122 into develop will increase coverage by 0.64%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop    #122      +/-   ##
==========================================
+ Coverage    66.66%   67.3%   +0.64%     
==========================================
  Files           11      11              
  Lines         1035    1040       +5     
  Branches       238     241       +3     
==========================================
+ Hits           690     700      +10     
+ Misses         309     305       -4     
+ Partials        36      35       -1
Impacted Files Coverage Δ
petab/sbml.py 61.66% <100%> (+6.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4009798...fb09010. Read the comment docs.

@paulstapor
Copy link
Contributor

I updated your branch, Daniel. Now the checks pass.
Feel free to merge whenever you want... 🙂

@dweindl
Copy link
Member Author

dweindl commented Aug 18, 2019

Thanks @paulstapor

@dweindl dweindl merged commit c378f90 into develop Aug 18, 2019
@dweindl dweindl deleted the fix_constant_species_to_parameters branch August 18, 2019 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants