Skip to content

Add pnpm support for the project #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 19, 2022

Conversation

jamesrweb
Copy link
Collaborator

Proposed Changes

  • Add PNPM support for the project to speed up installs, upgrades, etc of dependencies.
  • Update workflows to utilise pnpm over npm

Additional Notes (optional)

You can find a comparison video on their website and from my own testing, it is at least 3 times faster than NPM on my machine for administrative tasks related to dependencies.

@jamesrweb jamesrweb added enhancement dependencies Pull requests that update a dependency file labels Jun 19, 2022
@jamesrweb jamesrweb requested a review from yevdyko June 19, 2022 16:13
@jamesrweb jamesrweb self-assigned this Jun 19, 2022
@jamesrweb jamesrweb force-pushed the allow-project-pnpm-support branch from f0c9b53 to 64300a5 Compare June 19, 2022 16:15
Base automatically changed from update-dependencies to update-children-interactions June 19, 2022 16:20
@jamesrweb jamesrweb force-pushed the allow-project-pnpm-support branch from 64300a5 to 991ca03 Compare June 19, 2022 16:23
jamesrweb and others added 3 commits June 19, 2022 18:24
Co-authored-by: Eugene Dyko <yevdyko@gmail.com>
Co-authored-by: Eugene Dyko <yevdyko@gmail.com>
@jamesrweb
Copy link
Collaborator Author

@yevdyko merged the base branch into this one and resolved the conflicts now. 😄

Copy link
Collaborator

@yevdyko yevdyko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, pnpm is a good thing! the only thing that bothers me is that PR includes changes from the base branch and diff is wrong.

I assume that the CI workflow can be properly tested after the PR is merged.

@jamesrweb
Copy link
Collaborator Author

yeah, pnpm is a good thing! the only thing that bothers me is that PR includes changes from the base branch and diff is wrong.

I assume that the CI workflow can be properly tested after the PR is merged.

I will merge now and let's see then 😄

@jamesrweb jamesrweb merged commit fe440af into update-children-interactions Jun 19, 2022
@jamesrweb jamesrweb deleted the allow-project-pnpm-support branch June 19, 2022 16:32
@yevdyko
Copy link
Collaborator

yevdyko commented Jun 19, 2022

@yevdyko merged the base branch into this one and resolved the conflicts now. 😄

then it's ready to go 🐎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants