Update children interactions #168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the hook execution order is found
jamesrweb
added
bug
dependencies
jamesrweb
force-pushed
the
update-children-interactions
branch
2 times, most recently
from
04d4f5f to
a4cc592
Compare
jamesrweb
force-pushed
the
update-children-interactions
branch
from
a4cc592 to
dc39b9d
Compare
yevdyko
reviewed
Jun 19, 2022
There was a problem hiding this comment.
Thanks @jamesrweb for the enhancements!
I left a few minor comments and will check the examples code a bit later.
Co-authored-by: Eugene Dyko <yevdyko@gmail.com>
Co-authored-by: Eugene Dyko <yevdyko@gmail.com>
* update major changes in dependencies * Add pnpm support for the project * Update README.md Co-authored-by: Eugene Dyko <yevdyko@gmail.com> * Update README.md Co-authored-by: Eugene Dyko <yevdyko@gmail.com> Co-authored-by: Eugene Dyko <yevdyko@gmail.com>
jamesrweb
force-pushed
the
update-children-interactions
branch
from
7710b17 to
fd2438f
Compare
|
@yevdyko I am finished making changes here, the PR is ready for re-review. 😄 |
|
@yevdyko have you been able to review / test yet? If not, any idea when you'll get time? 😊 |
yevdyko
reviewed
Jun 26, 2022
There was a problem hiding this comment.
@jamesrweb I've tested the changes in the example app and the new example with styled-components, and they work as expected. Also left a few clarifying questions
|
@yevdyko updated the PR, it's ready for re-review now, thanks for the comments! 👍🏻 |
yevdyko
approved these changes
Jun 30, 2022
There was a problem hiding this comment.
It's ready to go! Thanks @jamesrweb for all these improvements 🚢
jamesrweb
added a commit
that referenced
this pull request
Aug 15, 2022
* Add example using a rotating plane * Cover and error for the runtime issue when a sketch is not provided * Update dependencies * Update logic to actually throw rather than log until a workaround for the hook execution order is found * Document how to handle the styling / positioning of children with a working example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #167
Proposed Changes
Additional Notes (optional)
Please check the local example app, ensure the documented example runs with the latest code as expected and feel free to comment on the new throwing behaviour. 😄