Skip to content

vkDestroyDescriptorPool added to Descriptor pool and sets #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 1, 2022
Merged

vkDestroyDescriptorPool added to Descriptor pool and sets #273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3594bff
vkDestroyDescriptorPool added
Onyrew Feb 28, 2022
87d4dc0
dots
Onyrew Feb 28, 2022
655d7f4
vkDestroyDescriptorPool added for French chapter
Onyrew Mar 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions en/05_Uniform_buffers/01_Descriptor_pool_and_sets.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,16 @@ automatically freed when the descriptor pool is destroyed. The call to
`vkAllocateDescriptorSets` will allocate descriptor sets, each with one uniform
buffer descriptor.

```c++
void cleanup() {
...
vkDestroyDescriptorPool(device, descriptorPool, nullptr);

vkDestroyDescriptorSetLayout(device, descriptorSetLayout, nullptr);
...
}
```

The descriptor sets have been allocated now, but the descriptors within still need
to be configured. We'll now add a loop to populate every descriptor:

Expand Down
10 changes: 10 additions & 0 deletions fr/05_Uniform_buffers/01_Descriptor_pool_et_sets.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,16 @@ Il n'est pas nécessaire de détruire les sets de descripteurs explicitement, ca
destruction de la pool. L'appel à `vkAllocateDescriptorSets` alloue donc tous les sets, chacun possédant un unique
descripteur d'UBO.

```c++
void cleanup() {
...
vkDestroyDescriptorPool(device, descriptorPool, nullptr);

vkDestroyDescriptorSetLayout(device, descriptorSetLayout, nullptr);
...
}
```

Nous avons créé les sets mais nous n'avons pas paramétré les descripteurs. Nous allons maintenant créer une boucle pour
rectifier ce problème :

Expand Down