vkDestroyDescriptorPool added to Descriptor pool and sets#273
Merged
Overv merged 3 commits intoOverv:masterfrom Mar 1, 2022
Onyrew:master
Merged
vkDestroyDescriptorPool added to Descriptor pool and sets#273Overv merged 3 commits intoOverv:masterfrom Onyrew:master
Overv merged 3 commits intoOverv:masterfrom
Onyrew:master
Conversation
Owner
|
Excellent, could you add it to the French version of the chapter as well? |
Contributor
Author
|
I added it, I think it should be in the right place. |
Owner
|
Thanks for fixing this :) |
Overv
pushed a commit
that referenced
this pull request
Mar 8, 2023
* vkDestroyDescriptorPool added * dots * vkDestroyDescriptorPool added for French chapter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The vkDestroyDescriptorPool is missing from the tutorial and vulkan gives a warning for it.
However it is present in the code examples in the github repo: 23_descriptor_sets.cpp