Skip to content

Conversation

@adriengivry
Copy link
Member

@adriengivry adriengivry commented Apr 30, 2025

Description

  • Updated premake5.lua files to be more consistent
    • Revised layout to improve readability/maintainability
    • Removed unnecessary includes (some projects where referencing some include dirs that they weren't actually using)
  • Moved (some) include statements from header files to source files and added forward declarations
    • This removes the need for a project (A) including another project (B) to have to also include dependencies from the other project (B)
  • Removed characterset ("MBCS") from a few libs (some still use some Windows-specific code that requires it), as this option isn't recommended anymore (unicode now preferred)
  • Disable warnings from dependencies (remove unnecessary noise)

Related Issues

Fixes #461
Fixes #465

Notes

As a side effect, these changes also improved build times:

Locally (Ryzen 9 3900x)

Before:

========== Build: 19 succeeded, 0 failed, 0 up-to-date, 0 skipped ==========
========== Build completed at 5:54 PM and took 04:37.363 minutes ==========

After:

========== Build: 19 succeeded, 0 failed, 0 up-to-date, 0 skipped ==========
========== Build completed at 5:48 PM and took 03:14.134 minutes ==========

Build Machine (GitHub)

On the build machine (GitHub workflow), it went down from 9m54 to 8m15s.

@adriengivry adriengivry force-pushed the refactor/sanitize_premake branch 2 times, most recently from c4e4cec to 2d14615 Compare April 30, 2025 20:50
@adriengivry adriengivry marked this pull request as ready for review April 30, 2025 21:44
@adriengivry adriengivry force-pushed the refactor/sanitize_premake branch from f372271 to ece6101 Compare April 30, 2025 21:56
@adriengivry adriengivry self-assigned this Apr 30, 2025
@adriengivry adriengivry added Refactoring Something that needs a refactoring Project Configuration Anything related to setuping our projects Cleanup Code cleanup and removed Refactoring Something that needs a refactoring labels Apr 30, 2025
@adriengivry adriengivry merged commit 27e6c91 into main May 10, 2025
@adriengivry adriengivry deleted the refactor/sanitize_premake branch May 10, 2025 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Cleanup Code cleanup Project Configuration Anything related to setuping our projects

Development

Successfully merging this pull request may close these issues.

Do a pass on premake5.lua files to remove unnecessary includes Remove dependdir .. "lua/lib" from OvEditor and OvGame premake files

2 participants