build: upgrade to angular 19 #78
Conversation
WalkthroughThis update upgrades Angular, PrimeNG, and related dependencies to newer versions, modifies the Angular project configuration to use PrimeFlex styles instead of PrimeNG themes, and introduces explicit PrimeNG theme initialization in the app module. Several components are marked as non-standalone, and minor stylesheet and global style adjustments are made. Changes
Sequence Diagram(s)sequenceDiagram
participant Browser
participant AppModule
participant PrimeNG
Browser->>AppModule: Application bootstrap
AppModule->>PrimeNG: initializePrimeNG (set theme: LaraLightBlue, darkModeSelector: false)
PrimeNG-->>AppModule: Theme configured
AppModule-->>Browser: App initialization continues
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (8)
🚧 Files skipped from review as they are similar to previous changes (8)
⏰ Context from checks skipped due to timeout of 90000ms (2)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
kshitij-k-osmosys
added
the
dependencies
kshitij-k-osmosys
force-pushed
the
build/angular-19
branch
from
40e686d to
01c94bf
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🧹 Nitpick comments (4)
apps/portal/angular.json (1)
51-53: Temporary budget increase—consider long-term fix
Bumping"maximumError"to"2.01mb"suppresses the build failure, but the underlying bundle remains oversized. I recommend replacing the CommonJSfile-saverimport with an ES module or using dynamic imports to shave off that ~4 KB.apps/portal/src/app/app.component.ts (1)
23-24:standalone: falseis redundant noise
standalonedefaults tofalse; adding it does not change behaviour and clutters every component decorator touched in this PR.
Unless you plan to toggle it dynamically, drop the property to keep the decorator lean.- styleUrls: ['./app.component.scss'], - standalone: false, + styleUrls: ['./app.component.scss'],apps/portal/src/app/app.module.ts (1)
115-122: Provider ordering looks OK but consider tree-shakingAdding
PrimeNGto providers forces the whole library into the root bundle.
If you only need the theming API, inject it lazily inside the initializer instead of registering it globally to minimise bundle size.apps/portal/package.json (1)
31-40: PrimeFlex 3.x + PrimeNG 19.x style mismatchPrimeNG 19 ships with utilities expecting PrimeFlex 4.x.
Keepingprimeflex": "^3.3.1"may cause layout classes (e.g.flex,gap-3) to behave differently. Upgrade to^4to stay aligned.- "primeflex": "^3.3.1", + "primeflex": "^4.3.0",
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
apps/portal/package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (8)
apps/portal/angular.json(2 hunks)apps/portal/package.json(1 hunks)apps/portal/src/app/app.component.ts(1 hunks)apps/portal/src/app/app.module.ts(4 hunks)apps/portal/src/app/features/file-processor/file-processor.component.ts(1 hunks)apps/portal/src/app/features/transcript-analyzer/transcript-analyzer.component.scss(1 hunks)apps/portal/src/app/features/transcript-analyzer/transcript-analyzer.component.ts(1 hunks)apps/portal/src/styles.scss(1 hunks)
🔇 Additional comments (7)
apps/portal/src/styles.scss (1)
2-4: Global typography set correctly
Adding a basefont-familyensures consistent typography after removing the PrimeNG theme CSS.apps/portal/angular.json (1)
42-43: PrimeFlex imported in global styles
Integratingprimeflex.csshere aligns with the shift to utility-first styling. Confirm that no legacy PrimeNG theme files remain in the array.apps/portal/src/app/features/file-processor/file-processor.component.ts (1)
18-18: Explicit non-standalone flag—consistent with project
Marking this component asstandalone: falsealigns with the updated schematics defaults and other components.apps/portal/src/app/features/transcript-analyzer/transcript-analyzer.component.ts (1)
13-13: Explicit non-standalone flag—consistent with project
Addingstandalone: falsehere maintains consistency with the other components and the updated schematics defaults.apps/portal/src/app/app.module.ts (2)
1-9: APP_INITIALIZER import is fine – but guard against tree-shakabilityBecause
APP_INITIALIZERis always executed eagerly, any heavy-weight code inside the initializer (e.g. dynamic theme parsing) will be bundled in the first chunk and may undo your efforts to keep the main chunk under 2 MB.
Keep initialiser logic minimal and lazy-load heavy artefacts if possible.
22-23: Verify theme preset importThe current import assumes a default export:
import LaraLightBlue from '@primeng/themes/lara';In v19 the package exposes named presets:
import { LaraLightBlue } from '@primeng/themes/lara';The default-import form yields
undefined, soprimeng.theme.set()will throw at runtime.
Double-check the package typings or runnpm explore @primeng/themes -- lsto confirm.apps/portal/package.json (1)
17-44: Zone.js version may break Ng19 change detection
zone.js@0.15is currently only marked “next”. Angular 19 LTS still pegs to~0.14.x. Mixing the two has previously caused runtime errors (e.g.ZoneDelegate.invokeTaskundefined).
Pin to~0.14.2unless you have explicitly validated 0.15 with E2E tests.- "zone.js": "~0.15.1" + "zone.js": "~0.14.2"
apps/portal/src/app/features/transcript-analyzer/transcript-analyzer.component.scss
Show resolved
Hide resolved
apps/portal/src/app/features/transcript-analyzer/transcript-analyzer.component.ts
Show resolved
Hide resolved
osm-vishnukyatannawar
force-pushed
the
build/angular-19
branch
from
5d6a36c to
0682830
Compare
Portal PR Checklist
Task Link
Osmosys Developers must include the Pinestem task link in the PR.
REST-1549
Pre-requisites
PR Details
PR details have been updated as per the given format (see below)
feat: add admin login page)Additional Information
ready for reviewshould be added if the PR is ready to be reviewed)Description:
Update
osm-transcript-summarizerportal to angular 19List of commands
Related changes:
Additional notes:
Saw build errors to exceed the preset limit build limit of 2mb.
The library file-saver is commonjs and not of es6 format.
So added temporary fix in commit 5d6a36c. This is temporary and working on a fix for it.
Pending actions:
Screenshots:
npm install
Portal
Summary by CodeRabbit
New Features
Bug Fixes
Style
Chores