-
Notifications
You must be signed in to change notification settings - Fork 0
fix: primeng components #80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThe changes update the transcript analyzer component to use the latest PrimeNG file upload and message components, replacing deprecated tags and adjusting the template structure. Supporting module imports and styles are also updated to match these changes, with minor layout adjustments for improved alignment and display. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant TranscriptAnalyzerComponent
participant PrimeNG_FileUpload
participant PrimeNG_Message
User->>TranscriptAnalyzerComponent: Loads component
TranscriptAnalyzerComponent->>PrimeNG_FileUpload: Renders <p-fileupload>
User->>PrimeNG_FileUpload: Selects file
PrimeNG_FileUpload->>TranscriptAnalyzerComponent: Triggers file upload event
TranscriptAnalyzerComponent->>PrimeNG_Message: Displays info messages
User->>TranscriptAnalyzerComponent: Clicks summarize button
Possibly related PRs
Suggested reviewers
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🔭 Outside diff range comments (1)
apps/portal/src/app/features/transcript-analyzer/transcript-analyzer.component.html (1)
3-15
: Explicitly switch FileUpload tomode="basic"
to avoid accidental HTTP calls.
p-fileupload
defaults toadvanced
mode, which still prepares an HTTP request even if you hide the Upload button and leaveurl=""
.
Setting the component to basic clarifies intent (client-side only) and prevents future regressions if someone re-enables the button.- <p-fileupload + <p-fileupload + mode="basic"
🧹 Nitpick comments (1)
apps/portal/src/app/features/transcript-analyzer/transcript-analyzer.component.scss (1)
15-19
: Scope header styling to the feature to avoid leaking into other uploads.Styling the bare
.p-fileupload-header
selector applies globally; any other file-upload anywhere in the portal will inherit this centering.
Prefixing with the feature container keeps the rule local and future-proof.-.p-fileupload-header { +.transcript-analyzer .p-fileupload-header { display: flex; flex-direction: column; align-items: center; }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
apps/portal/src/app/features/transcript-analyzer/transcript-analyzer.component.html
(2 hunks)apps/portal/src/app/features/transcript-analyzer/transcript-analyzer.component.scss
(1 hunks)apps/portal/src/app/primeng.module.ts
(2 hunks)
🔇 Additional comments (2)
apps/portal/src/app/primeng.module.ts (1)
4-4
: PrimeNG migration looks correct – double-check thatMessagesModule
is fully removed.Importing
MessageModule
and wiring it into themodules
array is the right move for v19.
Just make sure no leftover references toMessagesModule
(or<p-messages>
) remain elsewhere in the project; otherwise the app will compile but throw a template error at runtime.Also applies to: 14-14
apps/portal/src/app/features/transcript-analyzer/transcript-analyzer.component.html (1)
16-29
: Nice replacement of<p-messages>
with per-pill<p-message>
components.The new structure is simpler, translation-friendly, and works with PrimeNG v19 variants.
No concerns here.
Portal PR Checklist
Task Link
Osmosys Developers must include the Pinestem task link in the PR.
REST-1594
Pre-requisites
PR Details
PR details have been updated as per the given format (see below)
feat: add admin login page
)Additional Information
ready for review
should be added if the PR is ready to be reviewed)Description:
Update primeng components and restore portal UI as it was before update
Related changes:
Messages
to active componentMessage
Screenshots:
Landing Page

Upload Transcripts

Error Message

Summary by CodeRabbit
Style
Bug Fixes