Skip to content

- Added npm and yarn package commands to create distributables (#22) #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

- Added npm and yarn package commands to create distributables (#22) #85

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b51646c
- Added npm and yarn package commands to create distributables (#22)
hemaljoshi Mar 29, 2025
8c1096b
Merge branch 'main' into main
Vijay-2005 May 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,14 @@
"test": "echo \"No tests defined. Please contribute if you like\" && exit 0",
"lint": "npx eslint .",
"start": "cross-env NODE_ENV=development concurrently \"tsc -p tsconfig.electron.json\" \"vite\" \"wait-on -t 30000 http://localhost:54321 && electron ./dist-electron/main.js\"",
"build": "cross-env NODE_ENV=production npm run clean && vite build && tsc -p tsconfig.electron.json",
<
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo? Not need

"build": "cross-env NODE_ENV=production rimraf dist dist-electron && vite build && tsc -p tsconfig.electron.json",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"build": "cross-env NODE_ENV=production rimraf dist dist-electron && vite build && tsc -p tsconfig.electron.json",
"build": "cross-env NODE_ENV=production npm run clean && vite build && tsc -p tsconfig.electron.json",

npm run clean already does what you defined again. Hence change not needed

"run-prod": "cross-env NODE_ENV=production electron ./dist-electron/main.js",
"package": "npm run build && electron-builder build",
"package-mac": "npm run build && electron-builder build --mac",
"package-win": "npm run build && electron-builder build --win"
"package": "yarn build && electron-builder build",
"package-mac": "yarn build && electron-builder build --mac",
"package-win": "yarn build && electron-builder build --win"
Comment on lines +14 to +16
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Essentially changed npm with yarn. What's the thought here?

=
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

??


},
"build": {
"appId": "com.chunginlee.interviewcoder",
Expand Down