- Added npm and yarn package commands to create distributables (#22) #85
+7
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hopter-pilot#22) @hemaljoshi's PR adds packaging commands for creating distributable versions of the application and improves documentation: ->Added Package Build Commands ->Added package-mac command to build macOS DMG files ->Added package-win command to build Windows installers ->Added package command for current platform ->Documentation Updates ->Added a dedicated "Building Distributable Packages" section in README ->Testing Performed Verified package commands work correctly on macOS Verified package commands work correctly on Windows Confirmed documentation accurately reflects the build process These changes make it easier for users to create distributable versions of the application without having to manually run electron-builder commands.
bhaumikmaan
requested changes
May 9, 2025
| @@ -8,11 +8,14 @@ | |||
| "test": "echo \"No tests defined. Please contribute if you like\" && exit 0", | |||
| "lint": "npx eslint .", | |||
| "start": "cross-env NODE_ENV=development concurrently \"tsc -p tsconfig.electron.json\" \"vite\" \"wait-on -t 30000 http://localhost:54321 && electron ./dist-electron/main.js\"", | |||
| "build": "cross-env NODE_ENV=production npm run clean && vite build && tsc -p tsconfig.electron.json", | |||
| < | |||
| "package": "yarn build && electron-builder build", | ||
| "package-mac": "yarn build && electron-builder build --mac", | ||
| "package-win": "yarn build && electron-builder build --win" | ||
| = |
| @@ -8,11 +8,14 @@ | |||
| "test": "echo \"No tests defined. Please contribute if you like\" && exit 0", | |||
| "lint": "npx eslint .", | |||
| "start": "cross-env NODE_ENV=development concurrently \"tsc -p tsconfig.electron.json\" \"vite\" \"wait-on -t 30000 http://localhost:54321 && electron ./dist-electron/main.js\"", | |||
| "build": "cross-env NODE_ENV=production npm run clean && vite build && tsc -p tsconfig.electron.json", | |||
| < | |||
| "build": "cross-env NODE_ENV=production rimraf dist dist-electron && vite build && tsc -p tsconfig.electron.json", | |||
There was a problem hiding this comment.
Suggested change
| "build": "cross-env NODE_ENV=production rimraf dist dist-electron && vite build && tsc -p tsconfig.electron.json", | |
| "build": "cross-env NODE_ENV=production npm run clean && vite build && tsc -p tsconfig.electron.json", |
npm run clean already does what you defined again. Hence change not needed
Comment on lines
+14
to
+16
| "package": "yarn build && electron-builder build", | ||
| "package-mac": "yarn build && electron-builder build --mac", | ||
| "package-win": "yarn build && electron-builder build --win" |
There was a problem hiding this comment.
Essentially changed npm with yarn. What's the thought here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@hemaljoshi's PR adds packaging commands for creating distributable versions of the application and improves documentation:
->Added Package Build Commands
->Added package-mac command to build macOS DMG files ->Added package-win command to build Windows installers ->Added package command for current platform
->Documentation Updates
->Added a dedicated "Building Distributable Packages" section in README
->Testing Performed
Verified package commands work correctly on macOS
Verified package commands work correctly on Windows Confirmed documentation accurately reflects the build process
These changes make it easier for users to create distributable versions of the application without having to manually run electron-builder commands.