Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use terminaltables3, migrate to pyproject.toml #95

Merged
merged 2 commits into from
Jul 31, 2024
Merged

use terminaltables3, migrate to pyproject.toml #95

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3073bfd
use terminaltables3
branchvincent Jul 27, 2024
d80ac52
migrate to pyproject.toml
branchvincent Jul 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions MANIFEST.in
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion keep/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
import time
import click
import requests
from terminaltables import AsciiTable
from terminaltables3 import AsciiTable
from textwrap import wrap

from keep import about
Expand Down
24 changes: 24 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
[project]
name = "keep"
version = "2.10.1"
description = "Personal shell command keeper"
readme = "README.md"
authors = [
{ name = "Himanshu Mishra", email = "himanshu.mishra.kgp@gmail.com" },
]
dependencies = ["PyGithub", "click", "requests", "terminaltables3"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should pin the version for PyGithub to 1.4.7 as was the case in requirements.txt

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's unpinned in setup.py though (which is what users see/install and I agree is the way to go):

keep/setup.py

Lines 28 to 33 in e6eadb9

install_requires=[
'click',
'requests',
'terminaltables',
'PyGithub'
],

requires-python = ">=3.8"

[project.urls]
Homepage = "https://github.com/orkohunter/keep"
Downloads = "https://github.com/orkohunter/keep/archive/master.zip"

[project.scripts]
keep = "keep.cli:cli"

[tool.flit.sdist]
include = ["completions/"]

[build-system]
requires = ["flit_core>=3.4"]
build-backend = "flit_core.buildapi"
2 changes: 1 addition & 1 deletion release.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@
# pip install twine wheel
rm -rf build/*
rm -rf dist/*
python setup.py sdist bdist_wheel
python -m build
twine upload dist/*
4 changes: 0 additions & 4 deletions requirements.txt
View file
Open in desktop

This file was deleted.

39 changes: 0 additions & 39 deletions setup.py
View file
Open in desktop

This file was deleted.