Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use terminaltables3, migrate to pyproject.toml #95

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

branchvincent
Copy link
Contributor

This switches terminaltables with terminaltables3 since the current maintainer lost PyPI access and had to republish under the new name (see matthewdeanmartin/terminaltables3#3 (comment))

Also, I took the opportunity to migrate to pyproject.toml, which is the modern replacement for setup.py

Copy link
Collaborator

@rahuliyer95 rahuliyer95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Will let @OrkoHunter take another pass and merge

authors = [
{ name = "Himanshu Mishra", email = "himanshu.mishra.kgp@gmail.com" },
]
dependencies = ["PyGithub", "click", "requests", "terminaltables3"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should pin the version for PyGithub to 1.4.7 as was the case in requirements.txt

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's unpinned in setup.py though (which is what users see/install and I agree is the way to go):

keep/setup.py

Lines 28 to 33 in e6eadb9

install_requires=[
'click',
'requests',
'terminaltables',
'PyGithub'
],

Copy link
Owner

@OrkoHunter OrkoHunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @branchvincent and Rahul!

@OrkoHunter OrkoHunter merged commit 9673f1f into OrkoHunter:master Jul 31, 2024
@branchvincent branchvincent deleted the terminaltables3 branch July 31, 2024 13:22
@branchvincent
Copy link
Contributor Author

thanks! any chance this will land in a release soon?

@OrkoHunter
Copy link
Owner

@OrkoHunter
Copy link
Owner

@rahuliyer95 Can you share your pypi.org username with me? I'm happy to add you as a maintainer on pypi.org. Right now I'm the sole maintainer there and it doesn't look good. 😁

@rahuliyer95
Copy link
Collaborator

@rahuliyer95 Can you share your pypi.org username with me? I'm happy to add you as a maintainer on pypi.org. Right now I'm the sole maintainer there and it doesn't look good. 😁

It's rahuliyer95

@branchvincent
Copy link
Contributor Author

awesome thank you @OrkoHunter!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants