-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use terminaltables3, migrate to pyproject.toml #95
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Will let @OrkoHunter take another pass and merge
authors = [ | ||
{ name = "Himanshu Mishra", email = "himanshu.mishra.kgp@gmail.com" }, | ||
] | ||
dependencies = ["PyGithub", "click", "requests", "terminaltables3"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should pin the version for PyGithub
to 1.4.7
as was the case in requirements.txt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's unpinned in setup.py
though (which is what users see/install and I agree is the way to go):
Lines 28 to 33 in e6eadb9
install_requires=[ | |
'click', | |
'requests', | |
'terminaltables', | |
'PyGithub' | |
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @branchvincent and Rahul!
thanks! any chance this will land in a release soon? |
@branchvincent Released 2.11 ! |
@rahuliyer95 Can you share your pypi.org username with me? I'm happy to add you as a maintainer on pypi.org. Right now I'm the sole maintainer there and it doesn't look good. 😁 |
It's rahuliyer95 |
awesome thank you @OrkoHunter! |
This switches
terminaltables
withterminaltables3
since the current maintainer lost PyPI access and had to republish under the new name (see matthewdeanmartin/terminaltables3#3 (comment))Also, I took the opportunity to migrate to
pyproject.toml
, which is the modern replacement for setup.py