separate components to folders and start fixing coding style #5
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| /node_modules | ||
| /dist | ||
| /app/utils/BFS.js | ||
|
Owner
Author
There was a problem hiding this comment. The BFS.js file caused too many errors/warnings and I wanted to address it separately
Collaborator
There was a problem hiding this comment. Next time disable in the problematic file. See how to disable files/directories/lines/blocks in eslint docs. |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| module.exports = { | ||
| "extends": "airbnb", | ||
|
Collaborator
There was a problem hiding this comment. If you're using JS instead of JSON, don't quote the keys.
Owner
Author
There was a problem hiding this comment. I assume you don't mean the specific rule names (all those kebab case rule name are not happy without their quotes..), right?
Collaborator
There was a problem hiding this comment. Right, |
||
| "plugins": ["react"], | ||
| "rules": { | ||
| "no-tabs": "off", | ||
| "react/jsx-uses-react": 2, | ||
| "react/jsx-uses-vars": 2, | ||
|
Collaborator
There was a problem hiding this comment. I always use words instead of numbers, so the reader doesn't need to guess what |
||
| "comma-dangle": ["error", { | ||
|
Collaborator
There was a problem hiding this comment. Inconsistent indentation |
||
| "arrays": "always-multiline", | ||
| "objects": "always", | ||
| "imports": "never", | ||
| "exports": "never", | ||
| "functions": "always-multiline" | ||
| }], | ||
| "react/jsx-filename-extension": ["error", { "extensions": [".js"] }], | ||
| "react/jsx-curly-spacing": ["error", "always", { "allowMultiline": true }], | ||
| // enforce spacing inside array brackets | ||
| 'array-bracket-spacing': ['error', 'always'], | ||
| 'react/forbid-prop-types': [0, { forbid: ['any', 'array', 'object'] }], | ||
| }, | ||
| "globals": { | ||
|
Collaborator
There was a problem hiding this comment. I believe if you set the right environment (DOM), eslint will add these for you. |
||
| "window": true, | ||
| "document": true, | ||
| } | ||
| }; | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,2 @@ | ||
| /node_modules | ||
| /dist | ||
|
Collaborator
There was a problem hiding this comment. Use relative paths. |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are absolute paths. You need to use relative ones.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done