separate components to folders and start fixing coding style #5
Conversation
| @@ -0,0 +1,3 @@ | |||
| /node_modules | |||
| /dist | |||
| /app/utils/BFS.js No newline at end of file | |||
There was a problem hiding this comment.
The BFS.js file caused too many errors/warnings and I wanted to address it separately
There was a problem hiding this comment.
Next time disable in the problematic file. See how to disable files/directories/lines/blocks in eslint docs.
There's legitimate reasons to disable the linting on different resolutions and now that you lint, you should know how to disable the linter when you need to.
An ignore file is for permanently ignored files/directories - which isn't this case.
| @@ -0,0 +1,3 @@ | |||
| /node_modules | |||
There was a problem hiding this comment.
These are absolute paths. You need to use relative ones.
| @@ -0,0 +1,25 @@ | |||
| module.exports = { | |||
| "extends": "airbnb", | |||
There was a problem hiding this comment.
If you're using JS instead of JSON, don't quote the keys.
There was a problem hiding this comment.
I assume you don't mean the specific rule names (all those kebab case rule name are not happy without their quotes..), right?
There was a problem hiding this comment.
Right, extends doesn't need quoting, but "react/jsx-uses-react" has to be quoted to be syntactically correct.
| "no-tabs": "off", | ||
| "react/jsx-uses-react": 2, | ||
| "react/jsx-uses-vars": 2, | ||
| "comma-dangle": ["error", { |
There was a problem hiding this comment.
Inconsistent indentation
| "rules": { | ||
| "no-tabs": "off", | ||
| "react/jsx-uses-react": 2, | ||
| "react/jsx-uses-vars": 2, |
There was a problem hiding this comment.
I always use words instead of numbers, so the reader doesn't need to guess what 2 is.
| if (point === endP) { | ||
| return true; | ||
| } | ||
| return false; |
There was a problem hiding this comment.
const isEndPoint = (point) => point === endPoint
| return false; | ||
| } | ||
| // tests if a certain point can be used (inside the board && allowed to be stepped in && was not visited) | ||
| const legalPoint = function (point) { |
| if (inField(point)) { | ||
| if (allowedStep(point)) { | ||
| if (!visited(point)) { | ||
| return true; |
There was a problem hiding this comment.
return predicateOne(point) && predicateTwo(point) && predicateThree(point)
| const pathExists = function () { | ||
| if (legalPoint(startP) && legalPoint(endP)) { | ||
| const testingQue = [ startP, ]; | ||
| field[testingQue[0][0]][testingQue[0][1]].stepVisited = 0; |
There was a problem hiding this comment.
Use destructuring to replace these numbers with something a human can understand.
| @@ -5,22 +5,38 @@ | |||
| "main": "index.js", | |||
There was a problem hiding this comment.
This comment is about dist/index_bundle.js file: it should be git ignored. Not source code? Should not be versioned.
There was a problem hiding this comment.
sorry, didn't understand that one...
|
Very nice progress. Next time don't merge, but assign me so we can discuss changes. |
2 participants
The current commit achieved the following: