Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draw optimizer #657

Merged
merged 8 commits into from
Mar 3, 2022
Merged

Draw optimizer #657

merged 8 commits into from
Mar 3, 2022

Conversation

Variable-ind
Copy link
Contributor

@Variable-ind Variable-ind commented Mar 1, 2022

Should improve drawing on large size canvas significantly faster, similar to pull #554 and may solve issue #501. I would like it if @SayakS also get credited cause he was also working on the same issue 😁

don't think this one's needed but doing it just in case...
@Variable-ind
Copy link
Contributor Author

Variable-ind commented Mar 1, 2022

I decided to put a limit to the amount of cache stored. i ran some tests and think a value of 2000 will be decent enough (i decided to change its value based on brush size).

Demonstration

Before

Before.mp4

After

After.mp4

Copy link
Member

@OverloadedOrama OverloadedOrama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@OverloadedOrama OverloadedOrama merged commit 57ea4d2 into Orama-Interactive:master Mar 3, 2022
@Variable-ind Variable-ind deleted the draw-optimizing branch April 28, 2022 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants