Optimize the drawing of large amounts of pixels #554
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move pixel-cache clearing to the `draw_end` function
OverloadedOrama
force-pushed
the
master
branch
from
b23c24b
to
1278553
Compare
OverloadedOrama
force-pushed
the
master
branch
2 times, most recently
from
5f1a44d
to
500a482
Compare
Merged
|
Superseded by #657. If you'd like to make more optimizations, feel free to open a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#501 complains of lag when drawing a lot of pixels at once, a major reason for this lag seems to be a lot of redundant drawing attempts. Using GDNative here or C# will probably help, but a lot can be gained by just optimizing the algorithms used.
Doing this right though will require me to take some time to understand the entire flow of how pixels are drawn, so I'm making this a draft pull request until i can be more sure that what I've done is correct.