Add Meshroom logging to run_reconstruction (#279) #281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebrahimebrahim
requested changes
Apr 21, 2025
Collaborator
ebrahimebrahim
left a comment
ebrahimebrahim
left a comment
There was a problem hiding this comment.
Nice, this will be super useful in SlicerOpenLIFU!
The CalledProcessError is also great because we can catch that in SlicerOpenLIFU and handle meshroom failures more gracefully
I like that the MeshRecon logger is separate from the Meshroom logger.
Small change requested
src/openlifu/nav/photoscan.py
Outdated
| text=True, | ||
| **kwargs, | ||
| ): | ||
| """Run a subprocess and stream its stdout and stderr output to separate handlers.""" |
Collaborator
There was a problem hiding this comment.
Could use a complete docstring here, with all the args laid out such as what check and text mean. Also type annotate the function
ebrahimebrahim
approved these changes
Apr 21, 2025
Collaborator
ebrahimebrahim
left a comment
ebrahimebrahim
left a comment
There was a problem hiding this comment.
Looks perfect, thank you!
ebrahimebrahim
force-pushed
the
issue_279_meshroom_logging
branch
from
91e1cd6 to
051c257
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add functionality to redirect Meshroom logs to the python logger.