STYLE: Enforce import of __future__ annotations (#106) #224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebrahimebrahim
force-pushed
the
remove_exception_for_future_annotations_import
branch
from
0ad85d1 to
2afdc81
Compare
arhowe00
reviewed
Mar 4, 2025
Contributor
arhowe00
left a comment
arhowe00
left a comment
There was a problem hiding this comment.
Looks good, I'd recommend modifying the commit message to also include the fact that ruff removed Optional[•] to use • | None, as I don't think it's related to __future__ annotations, but it's fine either way and ready to rebase and merge.
ebrahimebrahim
force-pushed
the
remove_exception_for_future_annotations_import
branch
from
2afdc81 to
31848dd
Compare
Collaborator
Author
It is related: only once future annotations become available can the |
Once __future__ annotations become available the `|` notation can be used in python 3.9. So ruff was here allowed to standardize type annotations based on that. This will help reduce confusion about linter complaints in the future.
ebrahimebrahim
force-pushed
the
remove_exception_for_future_annotations_import
branch
from
31848dd to
6d8d67d
Compare
arhowe00
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making the linter more strict on this makes it clear how to fix type annotation complaints, avoiding some confusing situations