Add static Database initialization function (#217) #220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds an empty database to the specified location with empty tables.
ebrahimebrahim
force-pushed
the
217-Add-tool-to-initialize-an-empty-database
branch
from
1cba17e to
cff5579
Compare
ebrahimebrahim
approved these changes
Mar 1, 2025
Collaborator
ebrahimebrahim
left a comment
ebrahimebrahim
left a comment
There was a problem hiding this comment.
Looks good! I added a small update to just return the new database. Threw in a unit test just because that was the easiest way for me to review the code
If you approve of my update please go ahead and rebase+merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #217
I did not test this because there is coverage over all the functions
Database.write_*, and otherwise I am only using pathlib. Let me know if I should add a test and I'll make a separate commit for that