Return new db in empty db initializer (#217)

Author: ebrahimebrahim

src/openlifu/db/database.py

@@ -1077,7 +1077,7 @@ def get_default_path():
         return Path(Database.get_default_user_dir()) / "Documents" / "db"
 
     @staticmethod
-    def initialize_empty_database(database_filepath : Path | str) -> None:
+    def initialize_empty_database(database_filepath : Path | str) -> "Database":
         """
         Initializes an empty database at the given database_filepath
         """
@@ -1092,4 +1092,4 @@ def initialize_empty_database(database_filepath : Path | str) -> None:
         new_db.write_user_ids([])
         new_db.write_subject_ids([])
         new_db.write_transducer_ids([])
-        #new_db.write_system_ids([])
+        return new_db

tests/test_database.py

@@ -44,6 +44,16 @@ def example_transducer(example_database : Database) -> Transducer:
         filename = Path(example_database.path)/"transducers/example_transducer/example_transducer.json",
         )
 
+def test_new_database(tmp_path:Path):
+    """Test that a new empty database can be created that more or less works"""
+    db1 = Database.initialize_empty_database(tmp_path/"db1")
+    db2 = Database.initialize_empty_database(str(tmp_path/"db2")) # make sure using string also works
+    assert len(db1.get_protocol_ids()) == 0
+    assert len(db1.get_user_ids()) == 0
+    assert len(db1.get_subject_ids()) == 0
+    assert len(db1.get_transducer_ids()) == 0
+
+
 def test_write_protocol(example_database: Database):
     protocol = Protocol(name="bleh", id="a_protocol_called_bleh")