Remove outdated comment in ERC-20

[alexfertel]

Missed this other outdated comment in #4964

[changeset-bot]

⚠️ No Changeset found

Latest commit: f034421

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[ernestognw]

On a side note, I was reviewing to make sure we're not missing something again in the docs, and turns out we're still warning users about approve frontrunning when we already deprecated the non-standard increaseAllowance and decreaseAllowance functions.

* IMPORTANT: Beware that changing an allowance with this method brings the risk
* that someone may use both the old and the new allowance by unfortunate
* transaction ordering. One possible solution to mitigate this race
* condition is to first reduce the spender's allowance to 0 and set the
* desired value afterwards:
* https://github.com/ethereum/EIPs/issues/20#issuecomment-263524729

I wonder if we should remove the warning. We agree is a theoretical issue but doesn't hurt anyone 🤔

[ernestognw]

The xref doesn't look good in the docs. Taking some time to test it in local

[ernestognw]

LGTM. Merging if CI pass

[alexfertel]

Thank you!

[ernestognw]

Testing @gitpoap-bot @alexfertel

[gitpoap-bot]

Congrats, @alexfertel ! You've earned a GitPOAP for your contribution!

GitPOAP: 2024 OpenZeppelin Contracts Contributor:

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.