Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove outdated comment in ERC-20 #4964

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Remove outdated comment in ERC-20 #4964

merged 1 commit into from
Mar 18, 2024

Conversation

alexfertel
Copy link
Contributor

No description provided.

@alexfertel alexfertel added the documentation Inline comments, guides, and examples. label Mar 18, 2024
@alexfertel alexfertel requested review from Amxx and ernestognw March 18, 2024 16:33
@alexfertel alexfertel self-assigned this Mar 18, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 18, 2024

⚠️ No Changeset found

Latest commit: 91ca449

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

ernestognw
ernestognw approved these changes Mar 18, 2024
View reviewed changes
Copy link
Member

@ernestognw ernestognw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are already explicit about this in other functions so I think this is fine.

As always, let's wait for @Amxx approval. Thanks!

@alexfertel alexfertel changed the title Remove outdated comment in ERC-20 doc comments Remove outdated comment in ERC-20 Mar 18, 2024
@ernestognw ernestognw merged commit 6ae2c17 into OpenZeppelin:master Mar 18, 2024
22 of 23 checks passed
@alexfertel alexfertel deleted the outdated-comment branch March 18, 2024 22:21
@alexfertel alexfertel mentioned this pull request Mar 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ernestognw ernestognw ernestognw approved these changes

@Amxx Amxx Amxx approved these changes

Assignees

@alexfertel alexfertel

Labels
documentation Inline comments, guides, and examples. ignore-changeset
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexfertel @Amxx @ernestognw