-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove SafeERC20.safePermit #4582
Merged
Merged
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
5f9a8e9
Remove SafeERC20.safePermit
Amxx c15706f
Document the danger of authentication using permit
Amxx ddd60b3
add changeset
Amxx cefc133
Update green-pumpkins-end.md
frangio 2f77daf
remove unused variables
frangio 92abe2c
Update green-pumpkins-end.md
frangio a6e37ad
use inheritdoc
frangio 9a8b2e8
add IERC20Permit on docs site
frangio db787f6
move recommendations to IERC20Permit
frangio 35664bf
remove broken link
frangio b09fb90
use full example
frangio c7c46ea
expand example
frangio c1c95aa
wording
frangio 487b3f9
Update IERC20Permit.sol
frangio File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev
Previous commit
Update IERC20Permit.sol
- Loading branch information
commit 487b3f9cdd0561e151d4965ca18590bba907209a
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like
IERC20Permit
is not listed in the docs site. (https://docs.openzeppelin.com/contracts/4.x/api/token/erc20)I added it in this PR, let's see if it looks nice.
When we have this interface/implementation separation I don't like having duplicate docs in the site. The same applies to
I/AccessManager
, for example. But if the interface is in the library it should be somewhere in the documentation... so I may have to accept adding it.Using
@inheritdoc
leads to more duplication but it might make it nicer to navigate than a link like "See IERC20Permit.permit".