Remove SafeERC20.safePermit #4582
Conversation
🦋 Changeset detectedLatest commit: 487b3f9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
It looks like IERC20Permit is not listed in the docs site. (https://docs.openzeppelin.com/contracts/4.x/api/token/erc20)
I added it in this PR, let's see if it looks nice.
When we have this interface/implementation separation I don't like having duplicate docs in the site. The same applies to I/AccessManager, for example. But if the interface is in the library it should be somewhere in the documentation... so I may have to accept adding it.
Using @inheritdoc leads to more duplication but it might make it nicer to navigate than a link like "See IERC20Permit.permit".
Added documentation about the danger of ERC20Permit as an authentication method.
Based on recommendations by @trust1995.
PR Checklist
npx changeset add)