Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge bug fixing commits into master branch #134

Merged
merged 5 commits into from
Jul 4, 2023
Merged

Merge bug fixing commits into master branch #134

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5461ead
SinkC: fix ProbeAckData clear previous buffer with the same address
Ivyfeather Dec 1, 2022
61ad60b
sinkc,mshr: when data is written back, sinkC feeds back to mshr
wakafa1 Feb 3, 2023
e44cf13
mshr: do not require w_sinkcack when do release
wakafa1 Feb 4, 2023
f5dbef7
mshr: do not delay source_d task if sinkC task is not finished yet
wakafa1 Feb 8, 2023
62211fc
Revert "mshr: do not delay source_d task if sinkC task is not finishe…
wakafa1 Jul 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
mshr: do not require w_sinkcack when do release
  • Loading branch information
@wakafa1 @poemonsense
wakafa1 authored and poemonsense committed Feb 5, 2023
commit e44cf13cfaf7ef2dacd2153860dd5dd6733dd6fe
2 changes: 1 addition & 1 deletion src/main/scala/huancun/noninclusive/MSHR.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -944,7 +944,7 @@ class MSHR()(implicit p: Parameters) extends BaseMSHR[DirResult, SelfDirWrite, S
val can_start = Mux(client_dir_conflict, probe_helper_finish, true.B)
io.tasks.source_a.valid := io.enable && (!s_acquire || !s_transferput) && s_release && s_probe && w_probeacklast && can_start
io.tasks.source_b.valid := io.enable && !s_probe && s_release
io.tasks.source_c.valid := io.enable && w_sinkcack && (!s_release || !s_probeack && s_writerelease && w_probeack)
io.tasks.source_c.valid := io.enable && (!s_release || !s_probeack && s_writerelease && w_sinkcack && w_probeack)
io.tasks.source_d.valid := io.enable && !s_execute && can_start && w_grant && s_writeprobe && w_sinkcack && w_probeacklast && s_transferput // TODO: is there dependency between s_writeprobe and w_probeack?
io.tasks.source_e.valid := !s_grantack && w_grantfirst
io.tasks.dir_write.valid := io.enable && !s_wbselfdir && no_wait && can_start
Expand Down