Merge bug fixing commits into master branch #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the data of the first Probe TtoB are stored in buffer due to !io.release.ready, the second Probe BtoN (maybe from ProbeHelper) also returns data and thus triggers ProbeAckDataCleaner Since ProbeAckDataCleaner are meant to clean multiple data from the same req, it should not be triggered between different reqs. MSHR task sent to SinkC indicates that the last ProbeAckData for this req has already arrived, so its data should be kept. Any following ProbeAckData, even with the exact same address, should be treated as a new term.
* Otherwise, the following error may occur * 1. mshr#0 releaseData, sent task to sinkC and finish * 2. task is buffered in sinkC, waiting data port to be ready * 3. mshr#1 do probe, sourceC read the OLD data from datastorage
Ivyfeather
approved these changes
Jul 4, 2023
…d yet" This reverts commit f5dbef7.
Ivyfeather
approved these changes
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.