Skip to content

Add new devices #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Apr 25, 2025
Merged

Add new devices #404

merged 12 commits into from
Apr 25, 2025

Conversation

Likewindovo0830
Copy link
Contributor

♻️ Current situation

Describe the current situation. Explain current problems, if there are any. Be as descriptive as possible (e.g., including examples or code snippets).

💡 Proposed solution

Describe the proposed solution and changes. How does it affect the project? How does it affect the internal structure (e.g., refactorings)?

⚙️ Release Notes

Provide a summary of the changes or features from a user's point of view. If there are breaking changes, provide migration guides using code examples of the affected features.

➕ Additional Information

If applicable, provide additional context in this section.

Testing

Which tests were added? Which existing tests were adapted/changed? Which situations are covered, and what edge cases are missing?

Reviewer Nudging

Where should the reviewer start? what is a good entry point?

@Minsheng
Copy link
Collaborator

reviewed and approved

@Minsheng Minsheng merged commit 9c5d787 into OpenWonderLabs:main Apr 25, 2025
@hsakoh
Copy link

hsakoh commented Apr 25, 2025

@Minsheng @Likewindovo0830
There are some unclear points regarding the changes in the pull request.

  1. It seems that the DeviceType for the K20 webhook is incorrect.

  2. The same issue applies to Keypad Vision.

  3. There is no Get device status topic for LockUltra.

  4. Do the calibrate, position, and isStuck fields for Relay Switch 2PM really exist?

  5. The table and sample of the webhook payload for Relay Switch 2PM are different.

  6. As a result of checking the actual RGBWW Strip Light 3 device,

Also, regarding a previous change (I have sent a correction PR #362)

  1. The changeParam command payload for K10 + ProCombo includes waterLevel, but such a feature does not exist.
  1. Regarding the webhook payload for Air Purifier (VOC, Table VOC, PM2.5, Table PM2.5)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants