Correct errors in the newly added device. #362
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Minsheng Could you review this pull request? |
* Remove the `waterLevel` property. It seems this was forgotten when copying from the S10 model.
* Remove the `drying` property. * Modify the description of the `mode` property to match the Status API. These changes appear to have been overlooked when copying from the Evaporative Humidifier (Auto-refill) model.
hsakoh
force-pushed
the
feature/patch1
branch
from
a3942a6 to
045d337
Compare
Merged
|
Include this in #405. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are based on assumptions about product features, as I do not have detailed knowledge of the actual API or Webhook specifications.
The following changes have been made.
changeParamcommand for K10+ Pro CombowaterLevelproperty.It seems to have been left unchanged when copied from the S10.
Webhook payload for 4 Air Purifier models
dryingproperty.modeproperty to match the StatusAPI.These also seem to have been left unchanged when copied from the Evaporative Humidifier (Auto-refill).
Or, does the StatusAPI have a range of 1 to 4, while the Webhook has a range of 1 to 8 (including fan levels)?