Skip to content

Conversation

colemancda
Copy link
Contributor

colemancda added 26 commits May 13, 2017 13:03
Was configured with invalid `String`. Should be configured with `Level`
for type safely and reduced overhead (`UInt8` vs reference counted
struct).
OpenStack Summit/OpenStack
Summit/PushNotificationManager.swift:[433,59] var 'unreadCount' is
internal and cannot be referenced from an '@inline(__always)' function
Don’t unnecessarily download video thumbnail for meta data
2017-05-19 11:09:56.940 OpenStackSummit[18749:8775524] *** Terminating
app due to uncaught exception 'NSInvalidArgumentException', reason:
'Unsupported function expression count:(tracks.events)'
We should request app store reviews in the app.

We will prompt the user to review the app in the App Store after certain events occur (e.g. event rated, video finished playing, about screen loaded) and if the following requirements are met:

Running iOS 10.3 or above
App has been running for at least 5 minutes
It's been a week since we last prompted the user for a review.
@colemancda colemancda self-assigned this May 19, 2017
@colemancda colemancda requested a review from gcutrini May 19, 2017 22:20
@colemancda colemancda merged commit 47dd0d9 into master May 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants