[tvOS] Improved video loading performance

Don’t unnecessarily download video thumbnail for meta data

Author: colemancda

OpenStack Summit/OpenStackSummitTV/EventDetailViewController.swift

@@ -26,6 +26,8 @@ final class EventDetailViewController: UITableViewController {
 
     private var data = [Detail]()
 
+    private var videoImage: UIImage?
+    
     // MARK: - Loading
 
     override func viewDidLoad() {
@@ -50,6 +52,7 @@ final class EventDetailViewController: UITableViewController {
 
         self.eventCache = Event(managedObject: managedObject)
         self.eventDetail = EventDetail(managedObject: managedObject)
+        self.videoImage = nil
 
         self.data = [Detail]()
 
@@ -140,12 +143,13 @@ final class EventDetailViewController: UITableViewController {
 
             if let thumbnailURL = URL(youtubeThumbnail: eventDetail.video!.youtube) {
 
-                cell.videoImageView.hnk_setImageFromURL(thumbnailURL, placeholder: nil, format: nil, failure: nil, success: { (image) in
+                cell.videoImageView.hnk_setImageFromURL(thumbnailURL, placeholder: nil, format: nil, failure: nil, success: { [weak self, cell] (image) in
 
                     cell.videoImageView.image = image
                     cell.playImageView.isHidden = false
                     cell.activityIndicator.stopAnimating()
                     cell.setNeedsDisplay()
+                    self?.videoImage = image
                 })
             }
 
@@ -169,7 +173,7 @@ final class EventDetailViewController: UITableViewController {
 
         case .video:
 
-            self.play(video: eventDetail.video!)
+            self.play(video: eventDetail.video!, cachedImage: videoImage)
 
         default: break
         }

OpenStack Summit/OpenStackSummitTV/PlayVideo.swift

@@ -13,7 +13,7 @@ import XCDYouTubeKit
 
 extension UIViewController {
 
-    func play(video: Video) {
+    func play(video: Video, cachedImage: UIImage? = nil) {
 
         // add to recently played
 
@@ -60,8 +60,7 @@ extension UIViewController {
                     metadata.append(descriptionItem)
                 }
 
-                if let thumbnailURL = URL(youtubeThumbnail: video.youtube),
-                    let data = NSData(contentsOf: thumbnailURL) {
+                func setImage(data: NSData) {
 
                     let item = AVMutableMetadataItem()
                     item.identifier = AVMetadataCommonIdentifierArtwork
@@ -71,6 +70,17 @@ extension UIViewController {
                     metadata.append(item)
                 }
 
+                if let image = cachedImage,
+                    let data = UIImagePNGRepresentation(image) as NSData? {
+                    
+                    setImage(data: data)
+                    
+                } else if let thumbnailURL = URL(youtubeThumbnail: video.youtube),
+                    let data = NSData(contentsOf: thumbnailURL) {
+                    
+                    setImage(data: data)
+                }
+                
                 return metadata
             }()
 

OpenStack Summit/OpenStackSummitTV/VideoSearchResultsViewController.swift

@@ -150,6 +150,8 @@ final class VideoSearchResultsViewController: CollectionViewController, UISearch
 
         let video = Video(managedObject: managedObject)
 
-        self.play(video: video)
+        let cell = collectionView.cellForItem(at: indexPath) as! VideoCell
+        
+        self.play(video: video, cachedImage: cell.imageView?.image)
     }
 }