feat: add sorting back to ViewRaid page#58
Merged
nobrayner merged 1 commit intoOpenSourceRaidGuild:mainfrom Jan 27, 2021
codyarose:codyaroseSortViewRaid
Merged
feat: add sorting back to ViewRaid page#58nobrayner merged 1 commit intoOpenSourceRaidGuild:mainfrom codyarose:codyaroseSortViewRaid
nobrayner merged 1 commit intoOpenSourceRaidGuild:mainfrom
codyarose:codyaroseSortViewRaid
Conversation
JacobMGEvans
approved these changes
Jan 27, 2021
nobrayner
approved these changes
Jan 27, 2021
Contributor
|
Weird about the onBlur thing... You've got me interested now 😛 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #51
Had to use
onBluron the select becausejsx-a11yrule complained. Apparently the recommended config disallowsonChangehandlers. Kind of messes up the way the select is used though: to make the sorting take effect you have to click off of the select after clicking an option.