Skip to content

feat: add sorting back to ViewRaid page#58

Merged
nobrayner merged 1 commit intoOpenSourceRaidGuild:mainfrom
codyarose:codyaroseSortViewRaid
Jan 27, 2021
Merged

feat: add sorting back to ViewRaid page#58
nobrayner merged 1 commit intoOpenSourceRaidGuild:mainfrom
codyarose:codyaroseSortViewRaid

Conversation

@codyarose
Copy link
Contributor

Fix #51
Had to use onBlur on the select because jsx-a11y rule complained. Apparently the recommended config disallows onChange handlers. Kind of messes up the way the select is used though: to make the sorting take effect you have to click off of the select after clicking an option.

@codyarose codyarose added the Type: Feature New Feature and/or functionality - significant code rewrite or additions label Jan 27, 2021
@codyarose codyarose requested a review from nobrayner January 27, 2021 08:56
@nobrayner
Copy link
Contributor

Weird about the onBlur thing... You've got me interested now 😛

@nobrayner nobrayner merged commit a27042f into OpenSourceRaidGuild:main Jan 27, 2021
@codyarose codyarose deleted the codyaroseSortViewRaid branch January 27, 2021 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Pending ⏳ Type: Feature New Feature and/or functionality - significant code rewrite or additions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Sorting back to ViewRaid page

3 participants