-
Notifications
You must be signed in to change notification settings - Fork 14
Closed
Labels
CTA: Help WantedCALL TO ACTION: Rally to Aid a fellow Raid Member!!!CALL TO ACTION: Rally to Aid a fellow Raid Member!!!Difficulty: Beginner 🤓Good for newbie to start Raiding!!Good for newbie to start Raiding!!Priority: High ⚠️This could slow down other Raid/Guild members OR effect Raid completion!!!This could slow down other Raid/Guild members OR effect Raid completion!!!Type: FeatureNew Feature and/or functionality - significant code rewrite or additionsNew Feature and/or functionality - significant code rewrite or additions
Milestone
Description
Previous Svelte version had a select to change the sorting of the ranking based on commits, additions, or deletions.
Currently no sort whatsoever has been applied. This should be added back in.
See the below for reference:
website/frontend/src/routes/dungeons/raids/ViewRaid.svelte
Lines 18 to 27 in 3367e37
| const userStatSorts: { | |
| [key: string]: (a: UserStats, b: UserStats) => number | |
| } = { | |
| commits: (a, b) => b.commits - a.commits, | |
| additions: (a, b) => b.additions - a.additions, | |
| deletions: (a, b) => b.deletions - a.deletions, | |
| } | |
| const userStatSortNames = Object.keys(userStatSorts) | |
| let currentSort = userStatSortNames[0] |
website/frontend/src/routes/dungeons/raids/ViewRaid.svelte
Lines 63 to 69 in 3367e37
| Sort by:<select bind:value={currentSort} disabled={data.commits <= 1}> | |
| {#each userStatSortNames as theSort} | |
| <option value={theSort}> | |
| {theSort} | |
| </option> | |
| {/each} | |
| </select> |
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
CTA: Help WantedCALL TO ACTION: Rally to Aid a fellow Raid Member!!!CALL TO ACTION: Rally to Aid a fellow Raid Member!!!Difficulty: Beginner 🤓Good for newbie to start Raiding!!Good for newbie to start Raiding!!Priority: High ⚠️This could slow down other Raid/Guild members OR effect Raid completion!!!This could slow down other Raid/Guild members OR effect Raid completion!!!Type: FeatureNew Feature and/or functionality - significant code rewrite or additionsNew Feature and/or functionality - significant code rewrite or additions