Skip to content

Add new resolution for banner image and compression for jpg #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
armandfardeau merged 2 commits into from
Aug 1, 2018
Merged

Add new resolution for banner image and compression for jpg #150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0db4dfc
:sparkles::wrench: Add new resolution for banner image and compression
armandfardeau Jul 27, 2018
9778413
Merge branch '0.12-stable' into 0.12-stable-better-banner-image
armandfardeau Aug 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion decidim-core/app/uploaders/decidim/banner_image_uploader.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
module Decidim
# This class deals with uploading banner images to ParticipatoryProcesses.
class BannerImageUploader < ImageUploader
process resize_to_limit: [1000, 200]
process resize_to_limit: [1200, 600]
process quality: 60
end
end
15 changes: 15 additions & 0 deletions decidim-core/config/initializers/carrierwave.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
# frozen_string_literal: true

module CarrierWave
module MiniMagick
# this method allow us to specify a quality for our image
# e.g. <process quality: 60>
def quality(percentage)
manipulate! do |img|
img.quality(percentage.to_s)
img = yield(img) if block_given?
img
end
end
end
end