Aeos Review #116
Draft
Aeos Review #116
+221,531
−5,009,003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed the condition for FLAG_LOCK_ON in the autoplay logic to simplify the state management. - Enhanced clarity in the mode iteration process when autoplay is enabled, ensuring smoother functionality without unnecessary checks. - Maintained existing functionalities while improving the overall code structure.
- Updated methods for managing global flags to improve clarity and consistency, renaming `has_flag` to `has_flags` and introducing `has_any_flags`. - Adjusted conditional checks throughout the Helios state handling logic to utilize the new flag methods, enhancing readability and maintainability. - Ensured existing functionalities remain intact while refining the overall code structure.
- Removed unnecessary whitespace in the conditional check for playing the current mode. - Improved code readability without altering the existing functionality.
- Renamed `has_any_flag` to `has_any_flags` for consistency with recent refactoring. - Improved clarity in the conditional check for conjure and lock on flags without changing functionality.
- Added explicit type casting to `Flags` in conditional checks for `has_any_flags` to enhance type safety. - Maintained existing functionality while improving code clarity and consistency.
- Replaced direct call to `toggle_flag` with `handle_state_toggle_flag` for improved consistency in flag management. - Updated the `handle_state_toggle_flag` method to use `toggle_flags`, enhancing clarity in the flag toggling process. - Maintained existing functionality while refining the code structure for better readability.
Kurt/aeos/lock-on
- Updated the conditional check for invalid global flags to ensure factory reset is triggered only when flags are valid. - Enhanced code clarity by refining the logic without altering existing functionality.
- Introduced validation for global flags and brightness settings during loading, ensuring proper initialization. - Implemented factory reset logic when flags are invalid or brightness is zero, improving robustness against uninitialized storage. - Reset global brightness to default during factory reset to maintain consistent behavior.
- Cleaned up the test files by removing excessive instances of the color code `FF0000` and replaced it with `000000` or other relevant codes where necessary. - Enhanced readability and maintainability of the test cases by reducing clutter and ensuring consistent color usage across tests.
- Updated the flag checking logic to improve clarity and consistency across the codebase. - Renamed methods and streamlined the process for managing global flags, ensuring better readability without altering existing functionality.
…lt-autoplay kurt/aeos/fix-default-autoplay
- Updated .gitignore to include exceptions for configuration files (*.conf), ensuring they are not ignored during version control.
…omebrew installation path
…se its default system configuration file automatically
…ibility with pickit5_updi, enhancing upload process for macOS and non-Darwin systems.
… definitions for AVRDUDE, simplifying the upload process and enhancing compatibility with t85 and usbtiny.
…ip type, simplifying the build process and ensuring compatibility with Homebrew installations.
…E configuration accordingly, improving compatibility for both Intel and Apple Silicon systems.
…-upload kurt/aeos/intel-mac-upload
…on and release for the aeos
…d existing patterns, and updated Makefile for aeos firmware. Adjusted argument parsing in cli_main.cpp to accommodate additional parameters and refined PNG/SVG generation scripts to use a virtual environment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use this PR to review the differences between Aeos and Helios
DO NOT MERGE THIS