Kurt/aeos/lock-on #138
Merged
Kurt/aeos/lock-on #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
livingkurt
commented
Aug 14, 2025
livingkurt
commented
- Updated logic to ensure the current pattern plays in lock on mode unless the button is held for a long duration, allowing for menu access.
- Simplified conditions for playing the current mode when not locked or in lock on state.
- Improved clarity in user interactions while maintaining existing functionalities.
- Introduced FLAG_LOCK_ON to manage a new state where the device remains on but locked. - Implemented STATE_TOGGLE_LOCK_ON to handle transitions into and out of lock on mode. - Updated state handling logic to prevent interactions when lock on is active, enhancing user experience. - Adjusted LED feedback to indicate lock on status, improving visual cues for users. - Ensured existing functionalities remain intact while integrating the new lock on feature.
- Updated logic to allow menu access when the button is pressed while in lock on mode. - Adjusted conditions for playing the current mode to include scenarios where the button is not pressed. - Changed LED indication for lock on mode from lime green to white for improved clarity. - Ensured that existing functionalities remain intact while enhancing user experience during lock on state.
- Updated logic to flash red only when the device is locked and short clicked, specifically for glow lock mode. - Removed the condition for lock on mode to improve clarity in user feedback during interactions. - Ensured existing functionalities remain intact while enhancing the user experience in locked states.
- Updated logic to ensure the current pattern plays in lock on mode unless the button is held for a long duration, allowing for menu access. - Simplified conditions for playing the current mode when not locked or in lock on state. - Improved clarity in user interactions while maintaining existing functionalities.
- Removed redundant instances of the color code 000000 across multiple test files to improve consistency. - Updated color codes to 3C3C3C in various tests for better visual representation. - Enhanced the maintainability of the test suite while preserving existing functionality. - Ensured uniformity in color selection across tests to improve clarity and readability.
- Simplified the logic by removing the condition for FLAG_LOCK_ON when checking if the device is locked. - Enhanced clarity in the state management for LED indications during locked states. - Maintained existing functionalities while improving the overall code structure.
- Modified the condition to load the current mode index from storage to account for both FLAG_CONJURE and FLAG_LOCK_ON. - Enhanced clarity in the logic for loading modes based on active flags, improving the overall state management. - Ensured existing functionalities remain intact while refining the handling of global flags.
- Removed numerous instances of the color code 000000 to enhance uniformity across the test suite. - Updated color codes to 3C3C3C for improved visual representation in various tests. - Enhanced maintainability and readability of the test files while ensuring existing functionalities remain intact.
Unreal-Dan
reviewed
Aug 15, 2025
- Included a comment in the load_global_flags function to explain that the Lock On feature prevents the current mode from reverting to the first mode upon reset. - Enhanced code documentation for better understanding of mode management logic.
- Removed the condition for FLAG_LOCK_ON in the autoplay logic to simplify the state management. - Enhanced clarity in the mode iteration process when autoplay is enabled, ensuring smoother functionality without unnecessary checks. - Maintained existing functionalities while improving the overall code structure.
- Updated methods for managing global flags to improve clarity and consistency, renaming `has_flag` to `has_flags` and introducing `has_any_flags`. - Adjusted conditional checks throughout the Helios state handling logic to utilize the new flag methods, enhancing readability and maintainability. - Ensured existing functionalities remain intact while refining the overall code structure.
- Removed unnecessary whitespace in the conditional check for playing the current mode. - Improved code readability without altering the existing functionality.
- Renamed `has_any_flag` to `has_any_flags` for consistency with recent refactoring. - Improved clarity in the conditional check for conjure and lock on flags without changing functionality.
- Added explicit type casting to `Flags` in conditional checks for `has_any_flags` to enhance type safety. - Maintained existing functionality while improving code clarity and consistency.
- Replaced direct call to `toggle_flag` with `handle_state_toggle_flag` for improved consistency in flag management. - Updated the `handle_state_toggle_flag` method to use `toggle_flags`, enhancing clarity in the flag toggling process. - Maintained existing functionality while refining the code structure for better readability.
Unreal-Dan
approved these changes
Aug 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.