Conversation
thomassedlmayer
changed the title
thomassedlmayer
force-pushed
the
fix/logical-lane-rule
branch
from
fdd540e to
cc68cdd
Compare
thomassedlmayer
changed the title
jdsika
approved these changes
Jul 23, 2025
jdsika
added
Bug
|
OSI CCB meeting 25.09.2025: group has approved the PR. |
Signed-off-by: Thomas Sedlmayer <tsedlmayer@pmsfit.de>
Signed-off-by: Thomas Sedlmayer <tsedlmayer@pmsfit.de>
Signed-off-by: Thomas Sedlmayer <tsedlmayer@pmsfit.de>
pmai
force-pushed
the
fix/logical-lane-rule
branch
from
cc68cdd to
1a9342c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LogicalLane::PhysicalLaneReferencehas a rulerefer_to: Lanewhich can not be checked because there is no specification of which field inside PhysicalLaneReference contains the relevant id to be checked.The
physical_lane_idfield has this rule as well (see here). There it can be properly checked.I removed the rule that is both redundant and incorrectly located. I guess the
refers_torule can only be used for Identifiers.Resolves #848