Skip to content

Add sensor-specific data to detected stationary objects #702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 24, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions osi_detectedobject.proto
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,34 @@ message DetectedStationaryObject
//
optional ColorDescription color_description = 5;

// Additional data that is specific to radar sensors.
//
// \note Field needs not to be set if simulated sensor is not a radar
// sensor.
//
optional RadarSpecificObjectData radar_specifics = 100;

// Additional data that is specific to lidar sensors.
//
// \note Field needs not to be set if simulated sensor is not a lidar
// sensor.
//
optional LidarSpecificObjectData lidar_specifics = 101;

// Additional data that is specific to camera sensors.
//
// \note Field needs not to be set if simulated sensor is not a camera
// sensor.
//
optional CameraSpecificObjectData camera_specifics = 102;

// Additional data that is specific to ultrasonic sensors.
//
// \note Field needs not to be set if simulated sensor is not an ultrasonic
// sensor.
//
optional UltrasonicSpecificObjectData ultrasonic_specifics = 103;

//
// \brief A candidate for a detected stationary object as estimated
// by the sensor.
Expand Down
2 changes: 1 addition & 1 deletion osi_sensorspecific.proto
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ message UltrasonicSpecificObjectData
//
optional double maximum_measurement_distance_sensor = 1;

// This value indicates the propability height for the classification in the
// This value indicates the probability height for the classification in the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now that I have corrected the typo I am not sure if "probability height" is even a proper english term haha

// calculated object.
//
// Unit: %
Expand Down