-
Notifications
You must be signed in to change notification settings - Fork 129
Add new message for BoundingBox sub-sections #685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
osi_common.proto
Outdated
|
||
// Sub-divisions of the overall bounding box of the BaseMoving object. | ||
// | ||
// \note The bounding box sections can include side mirrors for vehicles. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// \note The bounding box sections can include side mirrors for vehicles. | |
// \note The bounding box sections can include side mirrors, doors, etc. for vehicles. |
Hi @tbleher , hi Jakob Peintner, would you also like to give a review on this PR? |
osi_common.proto
Outdated
TYPE_LIMB = 7; | ||
TYPE_HEAD = 8; | ||
|
||
// TODO: Do we want to handle data for BaseStationary here as well? What problems would having this solve? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Outcome WG Other Models (21th Nov): We want to handle the most significant cases for stationary objects here as well (e.g. tree trunk, tree crown, ...).
// within the bounds of the \c #dimension . Currently there several accepted | ||
// exceptions to this rule, specifically the sub-sections for cargo, vehicle | ||
// side mirrors, and doors not in the their closed position. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Proposal: Move the text for the "exceptional cases" to the enum field where they would be used from.
// The wheel of a vehicle. | ||
// | ||
TYPE_WHEEL = 6; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Proposal: Mention the data encoded in MovingObject/VehicleAttributes/WheelData and in which case this one should be used, and how the 2 fields are different
I think the initative is a good one :)
So, speaking as someone creating agent models, it would be much more important to have the ability to segment an object such that one has the guarantee that some areas of the dimension are in fact free. For such use-cases, the exact type does not matter at all, and could be left out. Is there any user who cares about this (the type distinction) for static objects like trees and traffic lights? I can see how this is important for wheels vs mirrors and such, but not so much for crown vs trunk - I just want to have a better 3D approximation of the tree so the pedestrian can accurately walk around it. |
Signed-off-by: Nicholas Dunning <Nicholas.Dunning@bmw.de>
Signed-off-by: Nicholas Dunning <Nicholas.Dunning@bmw.de>
Signed-off-by: Nicholas Dunning <Nicholas.Dunning@bmw.de>
Signed-off-by: Nicholas Dunning <Nicholas.Dunning@bmw.de>
Change version naming for master branch, update Ubuntu image, and add Antora generator trigger. Signed-off-by: Philip Windecker <philip.windecker@avenyr.de> Signed-off-by: Philip Windecker <95633467+philipwindecker@users.noreply.github.com> Signed-off-by: Pierre R. Mai <pmai@pmsf.de> Signed-off-by: Nicholas Dunning <Nicholas.Dunning@bmw.de>
Since no secrets will be available for security reasons, do not try to trigger antora builds when those secrets are not available. Signed-off-by: Pierre R. Mai <pmai@pmsf.de> Signed-off-by: Nicholas Dunning <Nicholas.Dunning@bmw.de>
Aligns variability attribute description with existing enum description Signed-off-by: Thomas Sedlmayer <tsedlmayer@pmsfit.de> Signed-off-by: Nicholas Dunning <Nicholas.Dunning@bmw.de>
Reference to a related issue in the repository
Add a reference to a related issue in the repository.
Add a description
This PR proposes the addition of bounding box sub-sections to BaseMoving and BaseStationary objects, to help sub-divide and classify different parts of the overall object structure.
Some questions to ask:
What is this change?
What does it fix?
Is this a bug fix or a feature? Does it break any existing functionality or force me to update to a new version?
How has it been tested?
Take this checklist as orientation for yourself, if this PR is ready for the Change Control Board:
If you can’t check all of them, please explain why.
If all boxes are checked or commented and you have achieved at least one positive review, you can assign the label ReadyForCCBReview!