Fix traffic sign variability attribute description #671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomassedlmayer
added
the
Harmonisation
HendrikAmelunxen
approved these changes
Oct 25, 2022
thempen
added
the
ReadyForCCBReview
6 tasks
pmai
approved these changes
Nov 7, 2022
pmai
force-pushed
the
fix/ha/traffic-sign-variability
branch
from
5b01e22 to
9426fc1
Compare
Aligns variability attribute description with existing enum description Signed-off-by: Thomas Sedlmayer <tsedlmayer@pmsfit.de>
pmai
force-pushed
the
fix/ha/traffic-sign-variability
branch
from
9426fc1 to
a87746b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference to a related issue in the repository
Fixes the issue addressed by #623
Description
This change aligns the attribute description of Traffic Sign Variability with the current description of the respective enum (VARIABILITY_VARIABLE). According to the current enum description, the attribute Variability does not only indicate if a traffic sign is stationary or not, but also potentially signifies dynamic traffic signs that could change their type over time (e.g., signs on dynamic sign bridges).
The change does not break existing functionality but rather fixes an existing bug or lack of clarity in the attribute description of Variability.
Take this checklist as orientation for yourself, if this PR is ready for the Change Control Board: