Skip to content

Draft for discussion: Added element tricycle #663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

FlorianMueller87
Copy link
Contributor

@FlorianMueller87 FlorianMueller87 commented Aug 10, 2022

Reference to a related issue in the repository

Issue: #639

Add a description

ASAM OSI and ISO 23150 or AUTOSAR ADI have a common history. Unfortunately, the inner structure, the naming and the definitions of the standards are differentiated from each other. This makes the work of developers unnecessary complicated for mostly no technical reasons. All sides should strive to reduce inequality.

ASAM OSI need the entry TYPE_TRICYCLE for osi_objects – MovingObject - VehicleClassification – Type to be compatible with AUTOSAR ADI PotentiallyMovingObjectClassificationType.

Take this checklist as orientation for yourself, if this PR is ready for the Change Control Board:

  • My suggestion follows the style and contributors guidelines.
  • I have taken care about the documentation.
  • I have done the DCO signoff.
  • My changes generate no errors when passing CI tests.
  • I have successfully implemented and tested my fix/feature locally.
  • Appropriate reviewer(s) are assigned.

Additional context

ISO23150:2021 A.76 Enumeration: Potentially moving object classification type

@ThomasNaderBMW @jdsika @schmidtlorenz

Issue: OpenSimulationInterface#639
Signed-off-by: FlorianMueller87 <florian.b.mueller@gmx.de>
Signed-off-by: FlorianMueller87 <florian.b.mueller@gmx.de>
@FlorianMueller87 FlorianMueller87 force-pushed the feature/adding_tricycle_to_VehicleClassification_type branch from d56e646 to ffd2730 Compare August 11, 2022 15:59
@jdsika jdsika added the Harmonisation The Group in the ASAM development project working on harmonisation with other standards. label Oct 17, 2022
@jdsika jdsika added this to the V3.6.0 milestone Oct 17, 2022
@jdsika
Copy link
Contributor

jdsika commented Oct 17, 2022

Questions:

  • The first thing coming to mind is "what is the definition of a tricycle"? Is it the one from WW2 where we have a motorbike with a side car or is it rather a chrildrens toy?
  • If AUTOSAR sees the need for this type could you also provide their proper defintion, please?
  • The TRUCKS e.g. already have some pictures from Add TYPE_TRUCK to vehicle classifications #585 but most of the defintions are also lacking precision in description which needs further refinement (does AUTOSAR have some nice definitions there as well?)

TODO:

  • Define the SVGs for the small car and other types as well - this would be breaking change...
  • Comment from @pmai : Either have only one car and not separate by length or other attributes OR comment from @jdsika you define car types by different shapes like VAN, SEDAN, COMBI, etc

IMPORTANT:
Find the motivation for defining the different types. Sensor modelling, driving strategy?

Apart from these remarks I do not see a reason to not include this suggestion.

@thempen
Copy link
Contributor

thempen commented Nov 23, 2022

Harmonization discussion:
"What is a tricycle?"

  • With or without motor?
  • Bike with three wheels
  • TukTuk
  • Motorbike with side car
  • Trike
  • Vehicles with closed wheels (front/back)

Please clarify it in more detail.

@jdsika
Copy link
Contributor

jdsika commented Jan 18, 2023

Clarification:

  • We are currently all compliant with ISO23150 as the ENUMS in the document are just examples.
  • Opinion: If the ISO provides examples it should make them with the good practice of defining it well and giving an argumentation formthe need
  • If ADI has a stakeholder with a clear need for a definition then we are happy to discuss it.

@ClemensLinnhoff ClemensLinnhoff added the AUTOSAR ADI Topics connected to AUTOSAR ADI definition. label Mar 3, 2023
@thempen
Copy link
Contributor

thempen commented Jul 17, 2023

OtherModels and Harmonization feedback: Closed.

Basically it would be a good approach to harmonize all OpenX standards according to vehicle types. E.g. to avoid problems with traffic signs targeting some vehicle type group, and the vehicle types of OSI.

If needed, reopen, or create new PR with further description and reference this PR.

@thempen thempen closed this Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AUTOSAR ADI Topics connected to AUTOSAR ADI definition. Harmonisation The Group in the ASAM development project working on harmonisation with other standards.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ISO23150 compliance: Adding one new vehicle type to [MovingObject - VehicleClassification - Type]
4 participants